Skip to content

Add unit tests for get_user_specified_clinit_body #5081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

romainbrenguier
Copy link
Contributor

Based on #5078

  • Each commit message has a non-empty body, explaining why the change was made.
  • [na] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [na] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@romainbrenguier romainbrenguier force-pushed the unit-test/user-specified-clinit branch 2 times, most recently from cc5fe83 to d3005d2 Compare September 6, 2019 10:10
Check that the function does what is expected for some simple cases.
@romainbrenguier romainbrenguier force-pushed the unit-test/user-specified-clinit branch from d3005d2 to 5d91b1f Compare September 6, 2019 11:14
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 5d91b1f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126215997

@codecov-io
Copy link

Codecov Report

Merging #5081 into develop will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5081      +/-   ##
===========================================
+ Coverage    69.66%   69.67%   +0.01%     
===========================================
  Files         1319     1319              
  Lines       109250   109290      +40     
===========================================
+ Hits         76106    76150      +44     
+ Misses       33144    33140       -4
Impacted Files Coverage Δ
unit/testing-utils/expr_query.h 100% <ø> (+20%) ⬆️
...a_static_initializers/java_static_initializers.cpp 100% <100%> (ø) ⬆️
...bmc/src/java_bytecode/java_static_initializers.cpp 99.1% <0%> (+0.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78fc2b7...5d91b1f. Read the comment docs.

@romainbrenguier romainbrenguier merged commit 522ae30 into diffblue:develop Sep 6, 2019
@romainbrenguier romainbrenguier deleted the unit-test/user-specified-clinit branch September 6, 2019 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants