Skip to content

Remove string operations handled by models from string solver #5065

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 12, 2019
Merged

Remove string operations handled by models from string solver #5065

merged 6 commits into from
Sep 12, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Aug 28, 2019 •
edited
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe danpoe force-pushed the refactor/remove-string-operations-handled-by-models branch from d08c8c6 to d7963b9 Compare August 29, 2019 10:36
@codecov-io
Copy link

codecov-io commented Aug 29, 2019 •
edited
Loading

Codecov Report

Merging #5065 into develop will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5065      +/-   ##
===========================================
- Coverage    69.69%   69.68%   -0.01%     
===========================================
  Files         1321     1321              
  Lines       109360   109331      -29     
===========================================
- Hits         76219    76190      -29     
  Misses       33141    33141
Impacted Files Coverage Δ
...rs/strings/string_constraint_generator_valueof.cpp 80.6% <ø> (-1.03%) ⬇️
...c/java_bytecode/java_string_library_preprocess.cpp 96.81% <ø> (-0.08%) ⬇️
...lvers/strings/string_constraint_generator_main.cpp 84.48% <ø> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fab409d...48de77e. Read the comment docs.

allredj
allredj reviewed Aug 29, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d7963b9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125067466

@danpoe danpoe force-pushed the refactor/remove-string-operations-handled-by-models branch from d7963b9 to 21ee1e8 Compare August 30, 2019 09:45
allredj
allredj reviewed Aug 30, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 21ee1e8).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/125215224

@danpoe danpoe force-pushed the refactor/remove-string-operations-handled-by-models branch 3 times, most recently from 1000a9e to 621478e Compare September 9, 2019 13:09
allredj
allredj reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 1000a9e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126450199
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

allredj
allredj reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 621478e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126458601

@danpoe danpoe force-pushed the refactor/remove-string-operations-handled-by-models branch from 621478e to 48de77e Compare September 11, 2019 10:10
@danpoe
Remove string operations from preprocessing that are handled by models
10dc6e4
@danpoe
Add --cp <classpath> option for regression tests that now need models
9089858
@danpoe
Add classpath option to float to string test and mark it as KNOWNBUG
b32de0a 
The test previously passed by accident as it did not specify the models jar via
the classpath option of jbmc. Thus, the models were not loaded and the string
operations were nondet'ed, and verification failed as required by the test.
allredj
allredj reviewed Sep 11, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 48de77e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/126974176

@danpoe danpoe merged commit 57de946 into diffblue:develop Sep 12, 2019
@danpoe danpoe deleted the refactor/remove-string-operations-handled-by-models branch June 2, 2020 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@martin-cs martin-cs martin-cs approved these changes

@romainbrenguier romainbrenguier romainbrenguier approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

@thk123 thk123 Awaiting requested review from thk123

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@danpoe @codecov-io @smowton @martin-cs @romainbrenguier @allredj