Add goto_trace_constant_pointer_exprt #5034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
kroening
approved these changes
Aug 17, 2019
These are derivatives of constant_exprt which give a pointer's numerical address in the usual constant value slot, but which also have an operand giving its symbolic value (e.g. "0xabcd0004" vs. "&some_object + 4"
smowton
force-pushed
the
smowton/cleanup/constant-pointer-expr
branch
from
cfef69c to
58f8101
Compare
Codecov Report
@@ Coverage Diff @@
## develop #5034 +/- ##
========================================
Coverage 69.48% 69.48%
========================================
Files 1310 1310
Lines 108813 108813
========================================
Hits 75609 75609
Misses 33204 33204
Continue to review full report at Codecov.
|
allredj
reviewed
Aug 19, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 58f8101).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/123697861
| @@ -292,4 +292,28 @@ void show_goto_trace( | |||
| if(cmdline.isset("stack-trace")) \ | |||
| options.set_option("stack-trace", true); | |||
|
|
|||
| /// Variety of constant expression only used in the context of a GOTO trace, to | |||
| /// give both the numeric value and the symbolic value of a pointer. | |||
| class goto_trace_constant_pointer_exprt : public constant_exprt | |||
There was a problem hiding this comment.
I think this clarifies some things. But could you add what you put in the PR description as a documentation here to make it even clearer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are derivatives of constant_exprt which give a pointer's numerical address in the usual
constant value slot, but which also have an operand giving its symbolic value (e.g. "0xabcd0004"
vs. "&some_object + 4"