Rename constant evaluation regression folder names #5032
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renamed except IndexOf
romainbrenguier
approved these changes
Aug 16, 2019
allredj
reviewed
Aug 16, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 225d4ff).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/123485598
Codecov Report
@@ Coverage Diff @@
## develop #5032 +/- ##
========================================
Coverage 69.48% 69.48%
========================================
Files 1310 1310
Lines 108813 108813
========================================
Hits 75609 75609
Misses 33204 33204Continue to review full report at Codecov.
|
danpoe
approved these changes
Aug 16, 2019
Yes, I tend to agree - but maybe the best we can have a separate meeting about re-organising these regression tests and agree on some folder structures and naming conventions? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split from danpoe#1.
In this PR,
rename of constant evaluation regression folders
clang format
are addressed
Each commit message has a non-empty body, explaining why the change was made.
n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
n/a My commit message includes data points confirming performance improvements (if claimed).
n/a My PR is restricted to a single feature or bugfix.
White-space or formatting changes outside the feature-related changed lines are in commits of their own.