fix exprt::opX accesses in goto-instrument #5011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
requested review from
chrisr-diffblue,
danpoe,
hannes-steffenhagen-diffblue,
martin-cs,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
kroening
force-pushed
the
opX-goto-instrument
branch
from
6dd3a09 to
7a76092
Compare
hannes-steffenhagen-diffblue
approved these changes
Aug 13, 2019
| @@ -110,7 +110,7 @@ void goto_program2codet::scan_for_varargs() | |||
| to_side_effect_expr(r).get_statement() == ID_va_start) | |||
| { | |||
| assert(r.has_operands()); | |||
There was a problem hiding this comment.
This assertion is now unnecessary (to_unary_expr already does this)
src/goto-instrument/dot.cpp
Outdated
| @@ -41,7 +41,7 @@ class dott | |||
|
|
|||
| unsigned subgraphscount; | |||
|
|
|||
| std::list<exprt> function_calls; | |||
| std::list<binary_exprt> function_calls; | |||
There was a problem hiding this comment.
Since this is specifically containing function calls, could this be a more specific type than binary_exprt?
allredj
reviewed
Aug 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 7a76092).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122972476
This improves type safety.
kroening
force-pushed
the
opX-goto-instrument
branch
from
7a76092 to
494728d
Compare
smowton
reviewed
Aug 13, 2019
| @@ -315,7 +314,8 @@ goto_programt::const_targett goto_program2codet::convert_assign_varargs( | |||
| { | |||
| code_function_callt f( | |||
| symbol_exprt(ID_va_start, code_typet({}, empty_typet())), | |||
| {this_va_list_expr, to_address_of_expr(skip_typecast(r.op0())).object()}); | |||
| {this_va_list_expr, | |||
| to_address_of_expr(skip_typecast(to_unary_expr(r).op())).object()}); | |||
There was a problem hiding this comment.
I'd say make an exprt for a va_start or do nothing, the fake unary-op isn't really adding any safety
allredj
reviewed
Aug 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 494728d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122995092
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves type safety.