Skip to content

Add regression test for TG-2479 #5006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

yumibagge
Copy link
Contributor

Add a test that failed initially and fixed by smowton/cbmc/smowton/feature/synthesise-lambda-classes

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@yumibagge yumibagge requested review from LAJW and smowton August 12, 2019 11:13
@yumibagge yumibagge self-assigned this Aug 12, 2019
@codecov-io
Copy link

codecov-io commented Aug 12, 2019

Codecov Report

Merging #5006 into develop will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5006      +/-   ##
===========================================
- Coverage    69.44%   69.43%   -0.02%     
===========================================
  Files         1310     1310              
  Lines       108753   108736      -17     
===========================================
- Hits         75523    75497      -26     
- Misses       33230    33239       +9
Impacted Files Coverage Δ
src/solvers/strings/string_builtin_function.h 75.26% <0%> (-2.16%) ⬇️
src/analyses/goto_check.cpp 78.85% <0%> (-0.61%) ⬇️
src/ansi-c/expr2c.cpp 67.39% <0%> (-0.5%) ⬇️
src/goto-programs/builtin_functions.cpp 45.45% <0%> (-0.32%) ⬇️
src/ansi-c/c_typecheck_type.cpp 76% <0%> (-0.13%) ⬇️
src/solvers/strings/string_refinement.cpp 88.24% <0%> (-0.05%) ⬇️
src/goto-symex/goto_symex_state.h 100% <0%> (ø) ⬆️
src/solvers/strings/string_dependencies.h 100% <0%> (ø) ⬆️
src/ansi-c/scanner.l 63.91% <0%> (ø) ⬆️
src/ansi-c/c_typecheck_base.h 100% <0%> (ø) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ef8430...8a56cab. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 0db7ffa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122813182
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

if (x0 == 1) {
assert x0 == 0; // verification failure
} else {
assert x0 >= -1 || x0 < -1; // verification success
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assert true? Assert something nontrivial that you expect to pass instead.

@yumibagge yumibagge force-pushed the yb/jbmc-regression-tg-2479 branch from 0db7ffa to 8a56cab Compare August 12, 2019 16:06
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 8a56cab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122860324
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@yumibagge yumibagge force-pushed the yb/jbmc-regression-tg-2479 branch from 8a56cab to 4b296f2 Compare August 27, 2019 11:27
@yumibagge
Copy link
Contributor Author

@LAJW @smowton, the assertions are pretty much from Lukasz's but hopefully this is now satisfactory. Please review.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4b296f2).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/124743538

@yumibagge yumibagge merged commit 5a6e58b into diffblue:develop Aug 27, 2019
@yumibagge yumibagge deleted the yb/jbmc-regression-tg-2479 branch August 27, 2019 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants