[TG-8994] Tolerate a constant on the LHS of an assignment #4998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
owen-mc-diffblue
approved these changes
Aug 9, 2019
This can happen due to a parital write to a string constant, e.g. *(int*)"hello world". In real programs these would fault, but we must tolerate them because symex's over-approximate alias analysis means it may think they can happen when in fact they are forbidden by other constraints.
smowton
force-pushed
the
smowton/fix/lhs-string-constant
branch
from
3864ecf to
e98540f
Compare
allredj
reviewed
Aug 9, 2019
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: e98540f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/122587749
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
smowton
changed the title
peterschrammel
approved these changes
Aug 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This can happen due to a parital write to a string constant, e.g. (int)"hello world".
In real programs these would fault, but we must tolerate them because symex's over-approximate
alias analysis means it may think they can happen when in fact they are forbidden by other
constraints.