Skip to content

Make prefix filter operator const [TG-8603] #4971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

peterschrammel
Copy link
Member

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov-io
Copy link

Codecov Report

Merging #4971 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4971      +/-   ##
===========================================
+ Coverage    69.24%   69.27%   +0.03%     
===========================================
  Files         1309     1307       -2     
  Lines       108453   108143     -310     
===========================================
- Hits         75096    74916     -180     
+ Misses       33357    33227     -130
Impacted Files Coverage Δ
src/util/prefix_filter.h 100% <ø> (ø) ⬆️
src/util/prefix_filter.cpp 100% <100%> (ø) ⬆️
src/goto-symex/renaming_level.cpp 92.53% <0%> (-2.52%) ⬇️
src/statement-list/statement_list_entry_point.cpp 86.36% <0%> (-1.52%) ⬇️
src/util/expr_cast.h 89.47% <0%> (-1.44%) ⬇️
src/statement-list/scanner.l 76.44% <0%> (-1.39%) ⬇️
src/cpp/cpp_declarator_converter.cpp 76.06% <0%> (-0.99%) ⬇️
jbmc/src/java_bytecode/java_bytecode_parser.cpp 89.59% <0%> (-0.98%) ⬇️
src/goto-symex/goto_symex.cpp 96.42% <0%> (-0.35%) ⬇️
jbmc/unit/java-testing-utils/require_type.cpp 89.65% <0%> (-0.28%) ⬇️
... and 56 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b23476...64c16fa. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 64c16fa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/121490558
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@peterschrammel peterschrammel changed the title Make prefix filter operator const Make prefix filter operator const [TG-8603] Jul 31, 2019
@smowton smowton merged commit 5d2e8b9 into develop Aug 1, 2019
@peterschrammel peterschrammel deleted the make-prefix-filter-const branch August 1, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants