Skip to content

use sorted_symbol_names in show_symbol_table_brief_plain #4932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2019

Conversation

kroening
Copy link
Member

This saves a bit of code.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 4cd5ab1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/119891064

@codecov-io
Copy link

codecov-io commented Jul 20, 2019

Codecov Report

Merging #4932 into develop will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #4932      +/-   ##
===========================================
- Coverage    69.26%   69.26%   -0.01%     
===========================================
  Files         1307     1307              
  Lines       108087   108086       -1     
===========================================
- Hits         74866    74865       -1     
  Misses       33221    33221
Impacted Files Coverage Δ
src/goto-programs/show_symbol_table.cpp 90.6% <100%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1edf4d9...4cd5ab1. Read the comment docs.

@smowton smowton changed the title use shorted_symbol_names in show_symbol_table_brief_plain use sorted_symbol_names in show_symbol_table_brief_plain Jul 23, 2019
@kroening kroening merged commit 69a9528 into develop Jul 23, 2019
@kroening kroening deleted the use_sorted_symbol_names branch July 23, 2019 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants