Skip to content

Create auxiliary symbols with a different name than symbols in namespace [blocks: #4885] #4925

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 22, 2019
Merged

Create auxiliary symbols with a different name than symbols in namespace [blocks: #4885] #4925

merged 1 commit into from
Jul 22, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Jul 18, 2019 •
edited
Loading

This adds another version of get_fresh_aux_symbol which takes a namespace and
produces symbol names that are different from any of the symbols in the
namespace. This can be used to e.g. generate fresh symbols during symex that
don't clash with any of the existing symbols.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@danpoe
Create aux symbol with a different name than symbols in namespace
1e96324 
This adds another version of get_fresh_aux_symbol which takes a namespace and
produces symbol names that are different from any of the symbols in the
namespace. This can be used to e.g. generate fresh symbols during symex that
don't clash with any of the existing symbols.
allredj
allredj reviewed Jul 18, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1e96324).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/119627321

@danpoe danpoe changed the title Create auxiliary symbols with a different name than symbols in namespace Create auxiliary symbols with a different name than symbols in namespace [blocks: #4885] Jul 22, 2019
@danpoe danpoe added the blocker label Jul 22, 2019
@danpoe danpoe merged commit 565542d into diffblue:develop Jul 22, 2019
@danpoe danpoe deleted the feature/get-fresh-symbol-in-namespace branch June 2, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@owen-mc-diffblue owen-mc-diffblue owen-mc-diffblue approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@danpoe @smowton @allredj @owen-mc-diffblue