Add KNOWNBUG for multidimentional char array[TG-8466] #4896
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
yumibagge
commented
Jul 12, 2019
yumibagge
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- White-space or formatting changes outside the feature-related changed lines are in commits of their own.
romainbrenguier
approved these changes
Jul 12, 2019
| ^SIGNAL=0$ | ||
| -- | ||
| -- | ||
| Multidimentional char array used to cause a performance issue (test-gen 0.8.1). |
There was a problem hiding this comment.
I don't think it make sens to mention test-gen version here
| } | ||
| } | ||
| } | ||
| return 0; |
There was a problem hiding this comment.
⛏️ doesn't really matter, but I would prefer if the function was returning diff
| My.class | ||
| --function My.check2DCharArray --unwind 5 --max-nondet-array-length 10 | ||
| line 8 assertion at file My.java.*: FAILURE | ||
| line 11 assertion at file My.java.*: FAILURE |
There was a problem hiding this comment.
⛏️ maybe add an assertion that should succeed, like maybe for instance assert diff < 10
yumibagge
force-pushed
the
yb/jbmc-regression-multi-dimentional-char-array
branch
from
2c1c363 to
b99b6f7
Compare
yumibagge
changed the title
yumibagge
force-pushed
the
yb/jbmc-regression-multi-dimentional-char-array
branch
from
b99b6f7 to
a5fd2df
Compare
allredj
reviewed
Jul 12, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: a5fd2df).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/118979057
Codecov Report
@@ Coverage Diff @@
## develop #4896 +/- ##
========================================
Coverage 69.2% 69.2%
========================================
Files 1306 1306
Lines 107949 107949
========================================
Hits 74704 74704
Misses 33245 33245Continue to review full report at Codecov.
|
yumibagge
changed the title
LAJW
approved these changes
Jul 16, 2019
owen-mc-diffblue
approved these changes
Jul 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.