Skip to content

Check if operand is an index expr in simplify_function_application() #4766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2019

Conversation

danpoe
Copy link
Contributor

@danpoe danpoe commented Jun 7, 2019

Previously the same expression was accidentally checked twice.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: aee5e3d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114770302

@codecov-io
Copy link

codecov-io commented Jun 7, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@d841075). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4766   +/-   ##
==========================================
  Coverage           ?   68.51%           
==========================================
  Files              ?     1275           
  Lines              ?   105032           
  Branches           ?        0           
==========================================
  Hits               ?    71958           
  Misses             ?    33074           
  Partials           ?        0
Impacted Files Coverage Δ
src/util/simplify_expr.cpp 80.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d841075...0a72c1e. Read the comment docs.

@smowton
Copy link
Contributor

smowton commented Jun 8, 2019

@peterschrammel can override the apparent AWS outage

Previously the same expression was accidentally checked twice.
@danpoe danpoe force-pushed the fixes/simplify-startswith branch from aee5e3d to 0a72c1e Compare June 10, 2019 09:28
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 0a72c1e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114917888

@danpoe danpoe merged commit 86499a6 into diffblue:develop Jun 10, 2019
@danpoe danpoe deleted the fixes/simplify-startswith branch June 2, 2020 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants