Skip to content

Regularise the AWS CodeBuild Clang buildspecs #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Jun 4, 2019

Check out the diff vs. buildspec.yml and you'll see these are now much more regular.
This duplication and drift is a vindication of Travis' "matrix" approach if you ask me ;)

@@ -7,14 +7,15 @@ env:

phases:
install:
runtime-versions:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Runtime versions only works with the standard images, but none of the standard images works with clang-3.8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, removed that change

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(please re-review)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clang-3.8 is running (again) now, but weirdly it doesn't show up in github.

@smowton smowton force-pushed the smowton/fix/regularise-buildspecs branch from af23020 to 0a3d5a4 Compare June 4, 2019 15:27
@smowton smowton force-pushed the smowton/fix/regularise-buildspecs branch from 0a3d5a4 to af48cf4 Compare June 4, 2019 16:02
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: af23020).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114291201
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@codecov-io
Copy link

codecov-io commented Jun 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@bf5f7f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4750   +/-   ##
==========================================
  Coverage           ?   68.45%           
==========================================
  Files              ?     1271           
  Lines              ?   104837           
  Branches           ?        0           
==========================================
  Hits               ?    71766           
  Misses             ?    33071           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf5f7f7...5b34d28. Read the comment docs.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 0a3d5a4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114292320
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@smowton smowton force-pushed the smowton/fix/regularise-buildspecs branch from af48cf4 to 62b30a9 Compare June 4, 2019 16:59
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: af48cf4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114297470
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Check out the diff vs. buildspec.yml and you'll see these are now much more regular.
This duplication and drift is a vindication of Travis' "matrix" approach if you ask me ;)
@smowton smowton force-pushed the smowton/fix/regularise-buildspecs branch from 62b30a9 to 5b34d28 Compare June 6, 2019 08:49
@smowton
Copy link
Contributor Author

smowton commented Jun 6, 2019

Most of this having been duplicated by the clang-8 PR, this now just removes a single extraneous line.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 5b34d28).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114553988

@tautschnig tautschnig merged commit a613337 into diffblue:develop Jun 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants