-
Notifications
You must be signed in to change notification settings - Fork 274
Regularise the AWS CodeBuild Clang buildspecs #4750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regularise the AWS CodeBuild Clang buildspecs #4750
Conversation
buildspec-linux-clang-3.8.yml
Outdated
@@ -7,14 +7,15 @@ env: | |||
|
|||
phases: | |||
install: | |||
runtime-versions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runtime versions only works with the standard images, but none of the standard images works with clang-3.8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, removed that change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(please re-review)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-3.8 is running (again) now, but weirdly it doesn't show up in github.
af23020
to
0a3d5a4
Compare
0a3d5a4
to
af48cf4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: af23020).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114291201
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
Codecov Report
@@ Coverage Diff @@
## develop #4750 +/- ##
==========================================
Coverage ? 68.45%
==========================================
Files ? 1271
Lines ? 104837
Branches ? 0
==========================================
Hits ? 71766
Misses ? 33071
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 0a3d5a4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114292320
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
af48cf4
to
62b30a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: af48cf4).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114297470
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
Check out the diff vs. buildspec.yml and you'll see these are now much more regular. This duplication and drift is a vindication of Travis' "matrix" approach if you ask me ;)
62b30a9
to
5b34d28
Compare
Most of this having been duplicated by the clang-8 PR, this now just removes a single extraneous line. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 5b34d28).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114553988
Check out the diff vs. buildspec.yml and you'll see these are now much more regular.
This duplication and drift is a vindication of Travis' "matrix" approach if you ask me ;)