-
Notifications
You must be signed in to change notification settings - Fork 274
Travis clang-format, cpplint: Use the merge base #4740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Travis clang-format, cpplint: Use the merge base #4740
Conversation
That certainly did happen to me. |
181a74d
to
55a8272
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 181a74d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113876156
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 55a8272).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113879798
cab898b
to
3280c41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 3280c41).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113889235
Codecov Report
@@ Coverage Diff @@
## develop #4740 +/- ##
==========================================
Coverage ? 68.44%
==========================================
Files ? 1255
Lines ? 104094
Branches ? 0
==========================================
Hits ? 71250
Misses ? 32844
Partials ? 0 Continue to review full report at Codecov.
|
Double check: how does this behave on a push build? |
We previously looked at the diff to the current head of the target branch, which may have moved in comparison to the merge base of a pull request. Thus we sometimes ended up with spurious clang-format errors, talking about changes introduced in another PR.
3280c41
to
59baaab
Compare
Travis' documentation says: "The range of commits that were included in the push or pull request. (Note that this is empty for builds triggered by the initial commit of a new branch.)" So I'd expect that to work exactly the same way in both cases. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 59baaab).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113954417
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.
We previously looked at the diff to the current head of the target
branch, which may have moved in comparison to the merge base of a pull
request. Thus we sometimes ended up with spurious clang-format errors,
talking about changes introduced in another PR.