Skip to content

Revert "Use std::forward_list instead of std::map in irept by default" #4729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 29, 2019

This is an experiment to see whether NAMED_SUB_IS_FORWARD_LIST=1 is the
root cause of builds and tests taking >70 minutes on Travis when
previously they would only take 26 minutes. (confirmed)

This is now a clean revert of the second commit in #4458.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig marked this pull request as ready for review May 29, 2019 22:37
@tautschnig tautschnig changed the title Disable NAMED_SUB_IS_FORWARD_LIST by default [Do not review] Disable NAMED_SUB_IS_FORWARD_LIST by default May 29, 2019
@tautschnig tautschnig force-pushed the disable-forward-list branch from be29a84 to 4d020ce Compare May 29, 2019 23:54
@tautschnig tautschnig changed the title [Do not review] Disable NAMED_SUB_IS_FORWARD_LIST by default Revert "Use std::forward_list instead of std::map in irept by default" May 29, 2019
@tautschnig
Copy link
Collaborator Author

It seems that running the regression tests on Travis with NAMED_SUB_IS_FORWARD_LIST set takes a lot longer. This is not the expected behaviour, but while I investigate this we should just go back to the known-good state.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: be29a84).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113681045
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 4d020ce).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113682654
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants