Skip to content

Add CI compilation with clang++-3.8 #4718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2019

Conversation

romainbrenguier
Copy link
Contributor

This is to check that changes do not break compilation using
clang++-3.8, as happened with
#4699

  • Each commit message has a non-empty body, explaining why the change was made.
  • [na] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • [na] The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [na] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator

@kroening @romainbrenguier @peterschrammel Could this be moved into a new CodeBuild job instead to be properly run in parallel?

@peterschrammel
Copy link
Member

@kroening @romainbrenguier @peterschrammel Could this be moved into a new CodeBuild job instead to be properly run in parallel?

Yes, please move that into a new buildspec-linux-clang-3.8.yml file.

@romainbrenguier
Copy link
Contributor Author

@peterschrammel @tautschnig I added a new buildspec-linux-clang-3.8.yml file but it looks like only buildspec.yml and buildspec-windows.yml are run on CI

@peterschrammel
Copy link
Member

peterschrammel commented May 29, 2019

only buildspec.yml and buildspec-windows.yml are run on CI

I'll add that to codebuild

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7b1280f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113845577

@romainbrenguier romainbrenguier force-pushed the ci/clang branch 2 times, most recently from 872198f to 88abf60 Compare May 31, 2019 10:57
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 872198f).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113875367
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 88abf60).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113876083

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 7ef487a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114072123

This uses CodeBuild to run in parallel
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 45fc621).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/114079433

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@ba23989). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #4718   +/-   ##
==========================================
  Coverage           ?   68.46%           
==========================================
  Files              ?     1270           
  Lines              ?   104777           
  Branches           ?        0           
==========================================
  Hits               ?    71740           
  Misses             ?    33037           
  Partials           ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ba23989...45fc621. Read the comment docs.

@kroening kroening merged commit 4c38989 into diffblue:develop Jun 3, 2019
@romainbrenguier romainbrenguier deleted the ci/clang branch June 3, 2019 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants