Skip to content

User-provided function definitions take precedence over built-ins #4707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 30, 2019

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 27, 2019

We should not replace calls to functions that have a body provided by
the user by our built-in definitions. While function names starting with
"_" are reserved in C and thus users shouldn't be using them, it is
certainly not true that anything named "nondet_*" is exclusively to be
captured by our built-ins.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

We should not replace calls to functions that have a body provided by
the user by our built-in definitions. While function names starting with
"_" are reserved in C and thus users shouldn't be using them, it is
certainly not true that anything named "nondet_*" is exclusively to be
captured by our built-ins.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c08a090).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113333585

@tautschnig tautschnig merged commit 1ec7061 into diffblue:develop May 30, 2019
@tautschnig tautschnig deleted the nondet-body-fix branch May 30, 2019 12:22
@tautschnig tautschnig restored the nondet-body-fix branch December 27, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants