Skip to content

Value-set filtering: gracefully handle pointer arithmetic #4697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2019

Conversation

tautschnig
Copy link
Collaborator

Pointer arithmetic can yield expressions that are deemed constant for
the purpose of constant propagation (such as &x + 1), even though they
aren't actually constant_exprt.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Pointer arithmetic can yield expressions that are deemed constant for
the purpose of constant propagation (such as &x + 1), even though they
aren't actually constant_exprt.
@tautschnig tautschnig merged commit e794441 into diffblue:develop May 23, 2019
@tautschnig tautschnig deleted the fix-value-set-filtering branch May 23, 2019 11:10
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e739fbb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112912971

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants