-
Notifications
You must be signed in to change notification settings - Fork 273
Replace definition of value_sett::object_map_dt #4694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace definition of value_sett::object_map_dt #4694
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/blank/empty, otherwise lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-format isn't happy and +1 on using empty_object_map
instead of blank_object_map
, otherwise looks good, another nice piece of cleanup!
This is so that the class can be used by types that do not have a static `blank` field. A particular case which would be useful in our codebase is std::map.
Instead of defining a new class with the same interface as std::map and which use std::map internally, we use using and define outside the static field `blank` which is the only thing added to std::map. This simplifies a lot the code in the value_set class header.
490457c
to
fdfca41
Compare
This was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined.
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined.
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
The explicit definition of object_mapt equality was removed recently in pull request diffblue#4694 but it seems necessary when compiling with clang which would complain about it not being defined. Should fix diffblue#4699
Instead of defining a new class with the same interface as std::map and
which use std::map internally, we use using and define outside the
static field
blank
which is the only thing added to std::map.