Skip to content

Remove now-unused bitvector conversion exceptions #4691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2019
Merged

Remove now-unused bitvector conversion exceptions #4691

merged 1 commit into from
May 30, 2019

Conversation

tautschnig
Copy link
Collaborator

Byte-operator lowering no longer throws any exceptions, and thus don't
need to attempt to catch them either. Remove the entire infrastructure
built around these.

Fixes: #2103

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig mentioned this pull request May 22, 2019
Closed
@tautschnig tautschnig force-pushed the remove-flattening-exceptions branch from e7e6cab to f11e2b2 Compare May 22, 2019 19:04
@tautschnig tautschnig changed the title Remove now-unused bitvector conversion exceptions [depends-on: #4651] Remove now-unused bitvector conversion exceptions May 22, 2019
@tautschnig tautschnig force-pushed the remove-flattening-exceptions branch from f11e2b2 to 9fa366b Compare May 22, 2019 19:39
thk123
thk123 approved these changes May 28, 2019
View reviewed changes
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it was done in an earlier PR - this would have been easier to review I think if changes removing the throws were included too. But since this just removes apparently dead code lgtm.

src/util/throw_with_nested.h
#ifdef _MSC_VER
#include <stdexcept>
// TODO(tkiley): Nested exception logging not supported on windows due to a bug
// TODO(tkiley): in MSVC++ Compiler (diffblue/cbmc#2104):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add fixes #2104 to auto close the issue

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@tautschnig tautschnig force-pushed the remove-flattening-exceptions branch from 9fa366b to 2d5688a Compare May 29, 2019 17:48
@tautschnig
Copy link
Collaborator Author

I guess it was done in an earlier PR - this would have been easier to review I think if changes removing the throws were included too.

I have step-by-step removed the throws by actually implementing the cases, hence combining that into a single PR didn't seem like the best option. The more-or-less final step in getting rid of the throws was #4651.

@tautschnig tautschnig assigned martin-cs and unassigned thk123 May 29, 2019
@tautschnig
Remove now-unused bitvector conversion exceptions
2b4f35e 
Byte-operator lowering no longer throws any exceptions, and thus don't
need to attempt to catch them either. Remove the entire infrastructure
built around these.

Fixes: diffblue#2103
@tautschnig tautschnig force-pushed the remove-flattening-exceptions branch from 2d5688a to 2b4f35e Compare May 30, 2019 07:53
allredj
allredj reviewed May 30, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 2b4f35e).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/113718309

@tautschnig tautschnig merged commit 4e29f7e into diffblue:develop May 30, 2019
@tautschnig tautschnig deleted the remove-flattening-exceptions branch May 30, 2019 11:54
@tautschnig tautschnig restored the remove-flattening-exceptions branch December 27, 2020 06:42
@tautschnig tautschnig mentioned this pull request Jan 16, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@thk123 thk123 thk123 approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@tautschnig tautschnig

Labels
cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend boolean conversion to throw structured exceptions for other kinds of conversion error
7 participants
@tautschnig @smowton @thk123 @peterschrammel @allredj @kroening @martin-cs