Make check in XML output function a precondition #4682
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously this check would just lead to a silent return when trying to output an empty XML document. As per the comment this is actually an error. Also fixes one instance where this function was used incorrectly in goto-analyzer.
hannes-steffenhagen-diffblue
requested review from
chrisr-diffblue,
danpoe,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
| @@ -34,8 +34,7 @@ void xmlt::output(std::ostream &out, unsigned indent) const | |||
| // 'name' needs to be set, or we produce mal-formed | |||
| // XML. | |||
|
|
|||
| if(name.empty()) | |||
| return; | |||
| PRECONDITION(!name.empty()); | |||
There was a problem hiding this comment.
Good catch! - but should this also be an invariant/precondition in the constructor as well?
There was a problem hiding this comment.
That'd make xmlt not default constructible anymore which'd be a bigger change.
I'm also noticing that the xmlt class seems to be limited to a single piece of text content, rather than allowing text and markup to intersperse like normal xml, but that's also a different issue.
tautschnig
approved these changes
May 22, 2019
chrisr-diffblue
approved these changes
May 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously this check would just lead to a silent return when
trying to output an empty XML document. As per the comment this is
actually an error.
Also fixes one instance where this function was used incorrectly in
goto-analyzer.