Skip to content

Revert "Set max-nondet-string-length to 10000 by default" #4660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 16, 2019

Conversation

majakusber
Copy link

@majakusber majakusber commented May 16, 2019

Reverts #4643 which introduced a default value for max-nondet-string-length. Instead, the value will remain unbounded in CBMC by default and a default value will be defined in test-gen only.

@tautschnig
Copy link
Collaborator

+100 for distinguishing a verification tool (CBMC) from a test-input generator. Thank you @svorenova!

@majakusber
Copy link
Author

@tautschnig Thank you for pointing it out 👍
Test-gen PR is ready here: https://github.com/diffblue/test-gen/pull/3425

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: c35c16a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112055707

@tautschnig tautschnig merged commit 32e5d4f into develop May 16, 2019
@tautschnig tautschnig deleted the revert-4643-max-nondet-string-length-default branch May 16, 2019 12:00
@martin-cs
Copy link
Collaborator

I realise this patch caused a disproportionate amount of discussion on it's way in and it is not my intent to replicate that but, @svorenova -- why did you decide to revert this?

@majakusber
Copy link
Author

majakusber commented May 16, 2019

Because from the discussion it seemed like this is not desired for CBMC (or if it is, what the default should be), but it would be useful for test-gen. So basically to not limit CBMC users unnecessarily.

@martin-cs
Copy link
Collaborator

martin-cs commented May 16, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants