Skip to content

Check cbmc-library regressions for completeness #4658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

tautschnig
Copy link
Collaborator

@tautschnig tautschnig commented May 16, 2019

This will make sure that newly added library functions are also covered by
tests.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Jan 19, 2021

Codecov Report

Base: 78.36% // Head: 78.37% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (e8f5ffd) compared to base (3302184).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4658   +/-   ##
========================================
  Coverage    78.36%   78.37%           
========================================
  Files         1647     1647           
  Lines       189961   189984   +23     
========================================
+ Hits        148861   148895   +34     
+ Misses       41100    41089   -11     
Impacted Files Coverage Δ
src/solvers/flattening/bv_pointers.cpp 86.22% <100.00%> (+0.10%) ⬆️
src/util/simplify_expr.cpp 85.39% <100.00%> (+<0.01%) ⬆️
src/util/simplify_expr_int.cpp 88.29% <100.00%> (+0.20%) ⬆️
src/solvers/smt2/smt2_conv.cpp 68.73% <0.00%> (+0.06%) ⬆️
src/util/ieee_float.cpp 88.22% <0.00%> (+0.16%) ⬆️
src/ansi-c/expr2c.cpp 67.88% <0.00%> (+0.23%) ⬆️
src/solvers/smt2/smt2_parser.cpp 78.52% <0.00%> (+0.31%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tautschnig tautschnig marked this pull request as ready for review January 23, 2021 01:04
@tautschnig tautschnig assigned kroening and unassigned tautschnig Jan 23, 2021
@tautschnig tautschnig force-pushed the library-check branch 3 times, most recently from bc49a57 to 05d6e86 Compare January 25, 2021 09:25
@tautschnig tautschnig self-assigned this Jan 25, 2021
@tautschnig tautschnig changed the title Check cbmc-library regressions for completeness Check cbmc-library regressions for completeness [depends-on: #5780] Jan 25, 2021
@tautschnig
Copy link
Collaborator Author

#5780 fixes the CSmith failure.

@tautschnig tautschnig force-pushed the library-check branch 2 times, most recently from 720c033 to 26012d0 Compare January 26, 2021 01:46
@tautschnig tautschnig assigned tautschnig and unassigned tautschnig Jan 26, 2021
@tautschnig tautschnig removed their assignment Jan 29, 2021
@tautschnig tautschnig changed the title Check cbmc-library regressions for completeness [depends-on: #5780] Check cbmc-library regressions for completeness Mar 9, 2021
@tautschnig tautschnig force-pushed the library-check branch 2 times, most recently from 191d421 to 7e6024e Compare May 10, 2021 12:45
@tautschnig tautschnig self-assigned this Nov 20, 2022
@tautschnig tautschnig marked this pull request as draft November 25, 2022 10:30
@tautschnig tautschnig marked this pull request as ready for review November 25, 2022 11:40
@tautschnig tautschnig removed their assignment Nov 25, 2022
@tautschnig tautschnig force-pushed the library-check branch 2 times, most recently from 671d3a4 to ca7b6d9 Compare November 25, 2022 13:11
Copy link
Member

@peterschrammel peterschrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

In cbmc-library/, we organise regression tests by the name of the
library function they are exercising.
In cbmc-library/, we organise regression tests by the name of the
library function they are exercising.
This test has been built to exercise --nan-check, not necessarily to
exercise particular library functions (even when it does use library
functions).
In cbmc-library/, we organise regression tests by the name of the
library function they are exercising. Rename these tests with the
library function they exercise. For those not focussing on library
functions, move them to cbmc/ instead. As those tests are also run past
the cprover SMT solver, three tests newly demonstrated issues in the SMT
back-end.
These are all marked KNOWNBUG and need tweaking.
These are whitespace changes only.
This will make sure that newly added library functions are also covered by
tests.
@tautschnig tautschnig merged commit 97ffac6 into diffblue:develop Dec 6, 2022
@tautschnig tautschnig deleted the library-check branch December 6, 2022 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants