Skip to content

Add return_value_identifier function #4634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 9, 2019

Conversation

majakusber
Copy link

@majakusber majakusber commented May 9, 2019

This function was removed in #4616, I would like to bring it back - it makes return_value_symbol more abstract (no need to work with the RETURN_VALUE_SUFFIX string directly), there is at least one place where creating the whole symbol is not necessary and last but not least, the function was quite widely used in test-gen (so in order to update the cbmc pointer, this needs to be resolved).

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@@ -296,8 +296,7 @@ bool remove_returnst::restore_returns(

// do we have X#return_value?
const namespacet ns(symbol_table);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Looks like we no longer need this namespace.

@majakusber majakusber force-pushed the return-value-identifier branch from 56ca07c to 6acdb10 Compare May 9, 2019 14:06
@smowton smowton merged commit 0a28dd1 into diffblue:develop May 9, 2019
@majakusber majakusber deleted the return-value-identifier branch May 9, 2019 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants