C front-end: type check arguments to built-in functions #4628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
added a commit
that referenced
this pull request
May 13, 2019
…ation Fix simplification of pointer-object comparison [blocks: #4628]
tautschnig
force-pushed
the
rw_ok-typechecking
branch
from
8aed383 to
21f6bb9
Compare
tautschnig
changed the title
|
@kroening This is now ready for review. |
allredj
reviewed
May 13, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 21f6bb9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/111588958
We only sometimes did this, effectively relying on all other cases not
requiring any modifications to the expression by the type checker. The
case of passing an array to __CPROVER_{r,w}_ok showed that this wasn't
sufficient. Now fixed for all built-in functions handled by the type
checker.
tautschnig
force-pushed
the
rw_ok-typechecking
branch
from
21f6bb9 to
ef90a5a
Compare
allredj
reviewed
May 16, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ef90a5a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/112047103
kroening
approved these changes
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only sometimes did this, effectively relying on all other cases not
requiring any modifications to the expression by the type checker. The
case of passing an array to _CPROVER{r,w}_ok showed that this wasn't
sufficient. Now fixed for all built-in functions handled by the type
checker.
Working on this brought up further bugs, which have been fixed in #4627. Thus this PR requires #4627 to be merged first for tests to pass.