Skip to content

update buildspec to include JDK version #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2019
Merged

Conversation

kroening
Copy link
Member

@kroening kroening commented May 8, 2019

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
    -n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the buildspec-runtime branch 2 times, most recently from 0607b9b to 3ca3b3f Compare May 8, 2019 10:21
@tautschnig
Copy link
Collaborator

The build is now failing.

@kroening kroening force-pushed the buildspec-runtime branch from 3ca3b3f to 69163d2 Compare May 8, 2019 13:42
This is required by the newer Ubuntu 18 images.  In return, the JDK no
longer needs to be installed using apt-get.
@kroening kroening force-pushed the buildspec-runtime branch from 69163d2 to 9fdfea5 Compare May 8, 2019 13:58
@kroening
Copy link
Member Author

kroening commented May 8, 2019

It should be mentioned that Codebuild has no "runtime" setting for gcc/g++. Implicitly, that is gcc/g++ 7.0.

@kroening kroening merged commit f2468ef into develop May 8, 2019
@kroening kroening deleted the buildspec-runtime branch May 8, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants