Java class typet methodt #4618
Merged
Java class typet methodt #4618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kroening
commented
May 4, 2019
kroening
commented
- Each commit message has a non-empty body, explaining why the change was made.
- Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
added 2 commits
May 4, 2019 15:00
This will allow us to use it in java_class_typet.
This has three benefits: * Ordinary fields no longer have get_is_native/set_is_native, which isn't applicable. * Java methods now offer final/native getters/setters. * Java methods now have the type java_method_typet.
kroening
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
smowton
approved these changes
May 7, 2019
| return exceptions; | ||
| } | ||
|
|
||
| void add_throws_exceptions(irep_idt exception) |
There was a problem hiding this comment.
Agreed, but note that this is just moving existing code around. Will do a separate PR.
thk123
reviewed
May 7, 2019
|
|
||
| const componentst &components() const | ||
| const methodst &methods() const |
There was a problem hiding this comment.
Are there any users for this? It'd be good to include at least some in this PR so doesn't get deleted Perhaps a unit test for checking that a java class when loaded has the methods set?
kroening
pushed a commit
that referenced
this pull request
May 7, 2019
This is follow up for #4618, and a addresses a comment by Chris. The method only adds one exception, not multiple.
kroening
pushed a commit
that referenced
this pull request
May 7, 2019
This is follow up for #4618, and a addresses a comment by Chris. The method only adds one exception, not multiple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.