-
Notifications
You must be signed in to change notification settings - Fork 274
Simple conflict-resolution for JSON symbol tables #4613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple conflict-resolution for JSON symbol tables #4613
Conversation
You might want to look at whether the linker used for combining multiple C symbol tables suits your needs |
6a4adbb
to
fdf48b3
Compare
@smowton Is this what you had in mind? |
fdf48b3
to
bcec958
Compare
If it suits your needs, yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a chance to have this tested in some way? Though what I'm more worried about: the linker currently applies conflict resolution rules that seem acceptable with C code. Other languages might be more strict about those conflicts.
Instead of trying to merge them and throwing exception for every symbol conflict.
generated from Ada files. These are included as a documentation.
25e2eaf
to
e2880da
Compare
@tautschnig I've added a regression test here: a88a188. And then found out that there is a discrepancy between the condition in |
e2880da
to
b3b5ea4
Compare
between goto-program/remove-return and the respective validation check. Update the unit-test accordingly.
b3b5ea4
to
16e2a14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 16e2a14).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/111724200
Link JSON symbol tables via
linking(old_symtab, new_symtab, message_handler)
.Instead of trying to merge them and throwing exception for every symbol
conflict.