Skip to content

use optional for json file name #4597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 1, 2019
Merged

use optional for json file name #4597

merged 1 commit into from
May 1, 2019

Conversation

kroening
Copy link
Member

@kroening kroening commented May 1, 2019

This is follow-up of #4041. It avoids the use of an empty string as
indicator of 'no value'.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is follow-up of #4041.  It avoids the use of an empty string as
indicator of 'no value'.
@peterschrammel peterschrammel removed their assignment May 1, 2019
@tautschnig tautschnig merged commit 3c6293a into develop May 1, 2019
@tautschnig tautschnig deleted the json_file_name_opt branch May 1, 2019 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants