value-set-dereference: factor out should_ignore_value #4575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
chrisr-diffblue,
kroening,
martin-cs,
owen-mc-diffblue,
peterschrammel and
tautschnig
as code owners
tautschnig
reviewed
Apr 26, 2019
| @@ -77,16 +84,14 @@ exprt value_set_dereferencet::dereference(const exprt &pointer) | |||
| valuet value = | |||
| build_reference_to(*it, pointer, exclude_null_derefs, language_mode, ns); | |||
There was a problem hiding this comment.
This call needs to be amended as it is one of the reasons of the CI failures (Doxygen and clang-format are also unhappy).
owen-mc-diffblue
approved these changes
Apr 29, 2019
smowton
force-pushed
the
smowton/cleanup/factor-value-set-deref
branch
2 times, most recently
from
bbf4aac to
0adfa60
Compare
Rather than build_reference_to returning a tuple which may indicate a value is ignored, seperately test whether it ought to be ignored beforehand and then build references to those values which are not ignored.
smowton
force-pushed
the
smowton/cleanup/factor-value-set-deref
branch
from
0adfa60 to
9231d22
Compare
peterschrammel
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than build_reference_to returning a tuple which may indicate a value is ignored,
seperately test whether it ought to be ignored beforehand and then build references to those
values which are not ignored.