goto-symex-is-constant: treat x * sizeof(t) and sizeof(t) * x alike
#4574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
tautschnig
approved these changes
Apr 26, 2019
owen-mc-diffblue
approved these changes
Apr 29, 2019
smowton
force-pushed
the
smowton/fix/brittle-goto-symex-is-constant
branch
2 times, most recently
from
b8dd372 to
a85ed3b
Compare
|
@tautschnig turned out I can only unit-test this in mainline cbmc as its simplifier always wants to swap the operand order so the constant (sizeof) comes first. Still, that seems like a brittle requirement, so I've made a unit test to check that ordering isn't required. |
|
@smowton I feared as much, but this PR helps us stay out of trouble in light of the existing PRs that disable sorting in the simplifier. Thank you for adding a unit test! |
Previously it would refuse and allow constant propagation respectively.
smowton
force-pushed
the
smowton/fix/brittle-goto-symex-is-constant
branch
from
a85ed3b to
eb7fc4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously it would refuse and allow constant propagation respectively. (Needs a test)