Skip to content

Remove cprover_string_intern handling in the solver #4554

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

romainbrenguier
Copy link
Contributor

This has never been tested and should rather be handled by the models,
it is a Java specific feature.

  • Each commit message has a non-empty body, explaining why the change was made.
  • [na] Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • [na] Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • [na] My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • [na] White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Copy link
Collaborator

@romainbrenguier The test java_intern in strings-smoke-tests is now failing.

@romainbrenguier
Copy link
Contributor Author

@tautschnig

@romainbrenguier The test java_intern in strings-smoke-tests is now failing.

So I was wrong, it is tested. I added a model to fix the problem, and added a complementary test.

@romainbrenguier romainbrenguier removed their assignment Apr 30, 2019
This will become necessary when the String.intern implementation is
moved to models.
This has never been tested and should rather be handled by the models,
it is a Java specific feature.
We add a version of the test which should fail in addition to the one
that should pass.
@romainbrenguier romainbrenguier force-pushed the clean-up/string-intern branch from 08c72bb to 524c13f Compare April 30, 2019 20:13
@romainbrenguier romainbrenguier merged commit 7293aca into diffblue:develop May 1, 2019
@romainbrenguier romainbrenguier deleted the clean-up/string-intern branch May 1, 2019 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants