Restore recognition of dynamic objects #4537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
owen-mc-diffblue
approved these changes
Apr 15, 2019
|
Clang-format and the linter are failing |
These were accidentally disabled when distinguishing ID_is_dynamic_object (a predicate that tests whether an object is dynamic) from ID_dynamic_object (a reference to the object itself, similar to symbol_exprt). I also take the opportunity to restore pretty-printing of dynamic object expressions (while also keeping pretty-printing of the predicate).
smowton
force-pushed
the
smowton/fix/restore-dynamic-object
branch
from
86cf481 to
9014506
Compare
allredj
reviewed
Apr 15, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9014506).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108401786
|
How did you notice? |
tautschnig
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were accidentally disabled when distinguishing ID_is_dynamic_object (a predicate that tests
whether an object is dynamic) from ID_dynamic_object (a reference to the object itself, similar to
symbol_exprt). I also take the opportunity to restore pretty-printing of dynamic object expressions
(while also keeping pretty-printing of the predicate).
This partially reverts #4479