Skip to content

goto_symex now uses decision_proceduret API #4533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 18, 2019
Merged

goto_symex now uses decision_proceduret API #4533

merged 3 commits into from
Apr 18, 2019

Conversation

kroening
Copy link
Member

@kroening kroening commented Apr 14, 2019 •
edited by tautschnig
Loading

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening force-pushed the goto_symex_decision_procedure branch 4 times, most recently from 85b9d00 to f74a93b Compare April 14, 2019 13:23
@tautschnig
Copy link
Collaborator

This is failing all CI steps.

@tautschnig
Copy link
Collaborator

Each commit message has a non-empty body, explaining why the change was made.

Not quite true.

smowton
smowton approved these changes Apr 15, 2019
View reviewed changes
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change appears good (though of course CI disagrees :))

@kroening kroening force-pushed the goto_symex_decision_procedure branch 4 times, most recently from 09e01ff to bc111fb Compare April 17, 2019 20:32
Daniel Kroening added 2 commits April 17, 2019 22:03
models for literal_exprt
443ef3c 
This enables us to use decision_proceduret::get for handles that are
literal_exprt.
switch ssa_stept to handles
a5b114e 
'Handles' more general than the literalt data structure, which is specific
to propositional, CNF-based SAT.
@kroening kroening force-pushed the goto_symex_decision_procedure branch from bc111fb to 41efcba Compare April 17, 2019 21:04
goto symex now uses decision_proceduret interface
49b4407 
Use the the decision_proceduret interface in goto_symext instead of
prop_convt.  literalt values are replaced by handles.
@kroening kroening force-pushed the goto_symex_decision_procedure branch from 41efcba to 49b4407 Compare April 18, 2019 06:45
allredj
allredj reviewed Apr 18, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 49b4407).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108799985
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@tautschnig tautschnig merged commit 35c31bb into develop Apr 18, 2019
@tautschnig tautschnig deleted the goto_symex_decision_procedure branch April 18, 2019 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@tautschnig tautschnig tautschnig approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@danpoe danpoe Awaiting requested review from danpoe

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@romainbrenguier romainbrenguier Awaiting requested review from romainbrenguier

Assignees

@kroening kroening

Labels
Symbolic Execution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kroening @tautschnig @smowton @allredj @peterschrammel