Skip to content

Java bytecode conversion: inline or move temporaries #4532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 15, 2019
Merged

Java bytecode conversion: inline or move temporaries #4532

merged 3 commits into from
Apr 15, 2019

Conversation

tautschnig
Copy link
Collaborator

This is a cleanup follow-up to #4524 of various minor bits that I spotted while doing the review thereof.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Do not take a reference to a temporary
cec0869 
symbolt::symbol_expr returns and expression by value.
@tautschnig
Java bytecode conversion: inline or move temporaries
cc7eff6 
This avoids constructing short-lived temporary objects where their names
don't add value either.
@tautschnig
Use code_blockt::add(code, source_location)
1e9d135 
This simplifies the code and helps getting rid of some more temporaries.
allredj
allredj reviewed Apr 14, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 1e9d135).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108242344

@tautschnig tautschnig mentioned this pull request Apr 15, 2019
Merged
1 task
@tautschnig tautschnig merged commit 18459ef into diffblue:develop Apr 15, 2019
@tautschnig tautschnig deleted the 4524-follow-up branch April 15, 2019 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@peterschrammel peterschrammel peterschrammel approved these changes

@owen-mc-diffblue owen-mc-diffblue owen-mc-diffblue approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

@thk123 thk123 Awaiting requested review from thk123

Assignees

@tautschnig tautschnig

Labels
cleanup Java Front End
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @peterschrammel @allredj @owen-mc-diffblue