Clean up decision_proceduret API #4530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
decision_procedure2
branch
from
0866f10 to
beb8b1e
Compare
tautschnig
approved these changes
Apr 13, 2019
kroening
force-pushed
the
decision_procedure2
branch
2 times, most recently
from
c2b5bb2 to
f8f10d7
Compare
kroening
requested review from
cesaro,
cristina-david,
pkesseli and
smowton
as code owners
added 5 commits
April 14, 2019 10:59
This change adds three features: 1) Non-boolean expressions are returned verbatim. 2) Boolean expressions that are determined to be a constant (e.g., by means of constant folding) are returned as constants, to enable further optimisation by users. 3) Literals returned are frozen, to simplify incremental usage.
The literal-based interface is more specific, and cover_goals doesn't require anything beyond what decision_proceduret offers.
No methods of prop_convt are used.
prop_convt is an instance of decision_proceduret that uses propositional logic.
kroening
force-pushed
the
decision_procedure2
branch
from
f8f10d7 to
b885981
Compare
allredj
reviewed
Apr 14, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: b885981).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/108256619
peterschrammel
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up for #4497; see roadmap there.