Skip to content

functionst is a lowering, not a flattening #4511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2019
Merged

Conversation

kroening
Copy link
Member

No bit-flattening is happening in this reduction.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI isn't happy yet, but otherwise good to go.

@tautschnig tautschnig assigned kroening and unassigned tautschnig Apr 10, 2019
for(function_mapt::const_iterator it=
function_map.begin();
it!=function_map.end();
for(function_mapt::const_iterator it = function_map.begin();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ranged for ?

@kroening
Copy link
Member Author

CI is failing because the chocolatey servers are overloaded.

@kroening kroening force-pushed the functions-is-a-lowering branch from 4a27d8e to 358aa4c Compare April 10, 2019 20:55
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 73a513c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107874604

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 358aa4c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107876500

Daniel Kroening added 3 commits April 11, 2019 04:52
@tautschnig tautschnig force-pushed the functions-is-a-lowering branch from 358aa4c to f3b2587 Compare April 11, 2019 04:52
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: f3b2587).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107906655

@tautschnig tautschnig merged commit b3b94a6 into develop Apr 11, 2019
@tautschnig tautschnig deleted the functions-is-a-lowering branch April 11, 2019 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants