Remove unused class_identifier parameter from Java object factory #4506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
antlechner
commented
Apr 9, 2019
antlechner
commented
- Each commit message has a non-empty body, explaining why the change was made.
- n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
- n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
- n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
- n/a My commit message includes data points confirming performance improvements (if claimed).
- n/a My PR is restricted to a single feature or bugfix.
- n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.
added 2 commits
April 9, 2019 18:13
This parameter was only "used" in gen_nondet_struct_init, where it was assigned a new value before it was actually used.
Naming this variable only duplicates the information that is already given in the name of the function set_class_identifier.
antlechner
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
thomasspriggs
approved these changes
Apr 9, 2019
| set_class_identifier( | ||
| to_struct_expr(*initial_object), ns, struct_tag_typet(qualified_clsid)); | ||
| to_struct_expr(*initial_object), | ||
| ns, |
There was a problem hiding this comment.
💡 set_class_identifier doesn't actually use ns. So this parameter could probably be removed, however that is probably a change for another PR.
There was a problem hiding this comment.
It has a call to ns.follow. I still find it a bit strange that follow is defined only for namespaces and not for symbol tables, but that would definitely be a change for another (much bigger) PR. 🙂
allredj
reviewed
Apr 9, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: b97b80a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/107679876
smowton
approved these changes
Apr 10, 2019
peterschrammel
approved these changes
Apr 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.