Skip to content

Add tests for --java-assume-inputs-non-null #4503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2019
Merged

Add tests for --java-assume-inputs-non-null #4503

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added jbmc/regression/jbmc/assume-inputs-non-null/My.class
View file
Open in desktop
Binary file not shown.
41 changes: 41 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/My.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
class My {

String field;

public static void stringArrayArg(String[] arg) {
if (arg == null) {
assert false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 It might make the tests a little easier to comprehend if you only put the assert false in the branches that shouldn't be covered.
Indeed could even be written as non-coverage style:

assert(arg != null)

Then you only need to check for verification successful.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a slight preference for the branching solution (using ifs) as I would like to keep both assertions (to be sure that a trace exists at all), and I don't want to make too many assumptions as to whether the assert acts as a guard or not.

} else {
assert false;
}
}

public static void stringArg(String arg) {
if (arg == null) {
assert false;
} else {
assert false;
}
}

public static void classArg(Other arg) {
if (arg == null) {
assert false;
} else if (arg.stringField != null) {
assert false;
} else if (arg.otherField != null) {
assert false;
} else if (arg.other2Field != null) {
assert false;
}
}

public void field() {
if (field == null) {
assert false;
} else {
assert false;
}
}

}
Binary file added jbmc/regression/jbmc/assume-inputs-non-null/Other.class
View file
Open in desktop
Binary file not shown.
7 changes: 7 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/Other.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
class Other {

String stringField;
Other otherField;
Other2 other2Field;

}
Binary file added jbmc/regression/jbmc/assume-inputs-non-null/Other2.class
View file
Open in desktop
Binary file not shown.
5 changes: 5 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/Other2.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
class Other2 {

String string2Field;

}
16 changes: 16 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/class_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
CORE
My.class
--function My.classArg --java-assume-inputs-non-null
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
\[java::My.classArg:\(LOther;\)V.assertion.1\].*SUCCESS
\[java::My.classArg:\(LOther;\)V.assertion.2\].*FAILURE
\[java::My.classArg:\(LOther;\)V.assertion.3\].*FAILURE
\[java::My.classArg:\(LOther;\)V.assertion.4\].*FAILURE
--
^warning: ignoring
--
Check that --java-assume-inputs-non-null restricts inputs to non-null user-
defined objects.
Also verify that fields of input object are NOT constrained to be non-null.
13 changes: 13 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/field_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
CORE
My.class
--function My.field --java-assume-inputs-non-null
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
\[java::My.field:\(\)V.assertion.1\].*FAILURE
\[java::My.field:\(\)V.assertion.2\].*FAILURE
--
^warning: ignoring
--
Check that --java-assume-inputs-non-null does NOT constrain the fields of the
containing object to be non-null.
12 changes: 12 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/string_array_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
CORE
My.class
--function My.stringArrayArg --java-assume-inputs-non-null
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
\[java::My.stringArrayArg:\(\[Ljava/lang/String;\)V.assertion.1\].*SUCCESS
\[java::My.stringArrayArg:\(\[Ljava/lang/String;\)V.assertion.2\].*FAILURE
--
^warning: ignoring
--
Check that --java-assume-inputs-non-null restricts inputs to non-null arrays
13 changes: 13 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/string_array_no_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
CORE
My.class
--function My.stringArrayArg
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
\[java::My.stringArrayArg:\(\[Ljava/lang/String;\)V.assertion.1\].*FAILURE
\[java::My.stringArrayArg:\(\[Ljava/lang/String;\)V.assertion.2\].*FAILURE
--
^warning: ignoring
--
Sanity check: null inputs are allowed when not using
--java-assume-inputs-non-null.
12 changes: 12 additions & 0 deletions jbmc/regression/jbmc/assume-inputs-non-null/string_assume.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
CORE
My.class
--function My.stringArg --java-assume-inputs-non-null
^EXIT=10$
^SIGNAL=0$
^VERIFICATION FAILED$
\[java::My.stringArg:\(Ljava/lang/String;\)V.assertion.1\].*SUCCESS
\[java::My.stringArg:\(Ljava/lang/String;\)V.assertion.2\].*FAILURE
--
^warning: ignoring
--
Check that --java-assume-inputs-non-null restricts inputs to non-null strings