-
Notifications
You must be signed in to change notification settings - Fork 274
decision_proceduret interface #4497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+22
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -34,8 +34,14 @@ class decision_proceduret | |
void set_to_false(const exprt &expr); | ||
|
||
/// Convert a Boolean expression and return the corresponding literal | ||
/// This will go away, use handle(expr) instead | ||
virtual literalt convert(const exprt &expr) = 0; | ||
|
||
/// Generate a handle for an expression; this offers an efficient way | ||
/// to refer to the expression in subsequent calls to \ref get or | ||
/// \ref set_to | ||
virtual exprt handle(const exprt &expr) = 0; | ||
|
||
/// Result of running the decision procedure | ||
enum class resultt | ||
{ | ||
|
@@ -54,6 +60,7 @@ class decision_proceduret | |
|
||
/// Return value of literal \p l from satisfying assignment. | ||
/// Return tvt::UNKNOWN if not available | ||
/// This will go away, use get instead. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Mark as deprecated? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Will remove the usage first (not a lot). |
||
virtual tvt l_get(literalt l) const = 0; | ||
|
||
/// Print satisfying assignment to \p out | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,16 @@ Author: Daniel Kroening, [email protected] | |
\*******************************************************************/ | ||
|
||
#include "prop_conv.h" | ||
|
||
#include "literal_expr.h" | ||
|
||
#include <algorithm> | ||
|
||
exprt prop_convt::handle(const exprt &expr) | ||
{ | ||
return literal_exprt(convert(expr)); | ||
} | ||
|
||
/// determine whether a variable is in the final conflict | ||
bool prop_convt::is_in_conflict(literalt) const | ||
{ | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mark as deprecated? The sooner we mark it as deprecated, the earlier we can remove it ;-)