Constify collect_virtual_function_callees #4466
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
smowton
force-pushed
the
smowton/cleanup/allow-collect-callees-const-symbol-table
branch
from
edc313b to
0825a61
Compare
tautschnig
reviewed
Mar 31, 2019
| : ns(_symbol_table), | ||
| symbol_table(_symbol_table), | ||
| class_hierarchy(_class_hierarchy) | ||
| class remove_virtual_functionst : public get_virtual_calleest |
There was a problem hiding this comment.
Is "is-a" really the correct relationship? My guess would have been that remove_virtual_functionst uses-a/has-a get_virtual_calleest?!
There was a problem hiding this comment.
Sure, was really just minimising churn. Changed to use-a.
This was always a const operation in spirit, as it retrieves a set of potential virtual function overrides without making any changes to the GOTO program, but was recently changed to take a non- const symbol table because it shares code with remove_virtual_function(s), which indeed add new symbols to the symbol table. To once again allow calling collect_virtual_function_callees in a const context, this splits the implementation of remove_virtual_functions into those parts that require a non-const reference and those for which a const symbol table will suffice.
smowton
force-pushed
the
smowton/cleanup/allow-collect-callees-const-symbol-table
branch
from
0825a61 to
9bc196b
Compare
tautschnig
approved these changes
Mar 31, 2019
allredj
reviewed
Mar 31, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 9bc196b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106467703
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was always a const operation in spirit, as it retrieves a set of potential virtual function
overrides without making any changes to the GOTO program, but was recently changed to take a non-
const symbol table because it shares code with remove_virtual_function(s), which indeed add new
symbols to the symbol table.
To once again allow calling collect_virtual_function_callees in a const context, this splits the
implementation of remove_virtual_functions into those parts that require a non-const reference and
those for which a const symbol table will suffice.