Ensure typet constructor is always compatible with GCC 5's STL [blocks: #4458] #4460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel,
pkesseli and
smowton
as code owners
tautschnig
changed the title
4 tasks
smowton
approved these changes
Mar 30, 2019
| typet(irep_idt _id, typet _subtype) | ||
| : irept(std::move(_id), {}, {std::move(_subtype)}) | ||
| { | ||
| } | ||
| #else |
There was a problem hiding this comment.
Note this will also be used under Clang, which pretends to be gcc 4.2.1
There was a problem hiding this comment.
Ah, thanks a lot, I've added #defined(__clang__) to the above #if.
tautschnig
force-pushed
the
constructor-fix
branch
from
483c317 to
99ac6d4
Compare
When enabling NAMED_SUB_IS_FORWARD_LIST, compilation failed as the std::forward_list constructors shipped with GCC 5 do not support an empty initializer list. GCC 6 and later do not have any such problem.
tautschnig
force-pushed
the
constructor-fix
branch
from
99ac6d4 to
ca155d3
Compare
allredj
reviewed
Mar 30, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: ca155d3).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106425825
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When enabling NAMED_SUB_IS_FORWARD_LIST, compilation failed as the
std::forward_list constructors shipped with GCC 5 do not support an
empty initializer list. GCC 6 and later do not have any such problem.