Skip to content

Add test passing status info for Z3 and CVC4 #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 28, 2019

Conversation

allredj
Copy link
Contributor

@allredj allredj commented Mar 28, 2019

Add special tags to track the support of string functions by 3rd party solvers Z3 and CVC4.
Running the suite with 3rd party solvers allows to:

  • check the sanity of the suite
  • track support of string ops by these solvers, when we later benchmark cbmc against those.
  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@allredj allredj self-assigned this Mar 28, 2019
z3:
str.< not supported
Z3 [version 4.8.3 - 64 bit]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove that blank line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@allredj allredj force-pushed the smt2-3rdparty-knownbugs branch from 0deb7ab to 9f47f8d Compare March 28, 2019 17:57
Copy link
Contributor Author

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: 9f47f8d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106225418
Status will be re-evaluated on next push.
Common spurious failures include: the cbmc commit has disappeared in the mean time (e.g. in a force-push); the author is not in the list of contributors (e.g. first-time contributors); compatibility was already broken by an earlier merge.

@tautschnig tautschnig merged commit 42b2b34 into diffblue:develop Mar 28, 2019
@allredj allredj deleted the smt2-3rdparty-knownbugs branch March 29, 2019 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants