Skip to content

Do not unnecessary follow tag types when storing the boolbv mapping #4364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2019

Conversation

tautschnig
Copy link
Collaborator

Types in equations must match exactly, there is no need to follow tags
when checking for type consistency. Also, do not use a followed type
when storing the mapping. When retrieving a mapped value, assert type
consistency.

This is a bugfix, but apparently doesn't show up with current develop. Upcoming work such as field-sensitivity causes simplification to fail, because of the type inconsistency that boolbvt::get currently might introduce.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening
Copy link
Member

Those untyped expressions trouble me...

@tautschnig tautschnig self-assigned this Mar 11, 2019
@tautschnig
Copy link
Collaborator Author

Those untyped expressions trouble me...

Ack. We should benchmark whether there really is much value in those clock types being as-small-as-possible. Maybe it's just fine to make them size_type() or so.

Types in equations must match exactly, there is no need to follow tags
when checking for type consistency. Also, do not use a followed type
when storing the mapping. When retrieving a mapped value, assert type
consistency.
@tautschnig tautschnig force-pushed the mapping-dont-follow branch from c8ccf5c to 32a5f76 Compare March 11, 2019 11:53
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 32a5f76).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103892078

@tautschnig tautschnig merged commit 55ca2c6 into diffblue:develop Mar 11, 2019
@tautschnig tautschnig deleted the mapping-dont-follow branch March 11, 2019 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants