Skip to content

Make use of simple-slice more explicit #4360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 11, 2019
Merged

Make use of simple-slice more explicit #4360

merged 3 commits into from
Mar 11, 2019

Conversation

peterschrammel
Copy link
Member

@peterschrammel peterschrammel commented Mar 10, 2019 •
edited
Loading

Slicing may prevent you from getting a full trace (until the end of __CPROVER_start) despite calling build_full_trace.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@peterschrammel
Add missing modules to folder walkthrough
987a568 
goto-checker and goto-harness have been added recently.
@peterschrammel
Clarify influence of slicing on completeness of trace
0329191 
Slicing may prevent you from getting a full trace until
the end of __CPROVER_start despite calling build_full_trace.
@peterschrammel
Make use of simple-slice explicit
e048cf6 
Simple slicing was deactivated with --cover
inside a utility function.
Now, we activate simple-slice by default
and deliberately turn it off when --cover is present.
allredj
allredj reviewed Mar 10, 2019
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e048cf6).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103809660

@tautschnig tautschnig merged commit 2b2a62b into diffblue:develop Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@chrisr-diffblue chrisr-diffblue Awaiting requested review from chrisr-diffblue

@cristina-david cristina-david Awaiting requested review from cristina-david

@danpoe danpoe Awaiting requested review from danpoe

@hannes-steffenhagen-diffblue hannes-steffenhagen-diffblue Awaiting requested review from hannes-steffenhagen-diffblue

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@martin-cs martin-cs Awaiting requested review from martin-cs martin-cs is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@peterschrammel @smowton @allredj @tautschnig