Skip to content

Pass a message handler to is_goto_binary [blocks: #3867] #4341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 7, 2019

Conversation

tautschnig
Copy link
Collaborator

This is in preparation of support for goto-cc sections in OS X Mach-O
files (#3867), where we will want to report problems while attempting to read a
file.

I believe this will break TG, but @allredj had already prepared a bump for #3867 at https://github.com/diffblue/test-gen/pull/2857. Presumably that would still do the trick.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This is in preparation of support for goto-cc sections in OS X Mach-O
files, where we will want to report problems while attempting to read a
file.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️
This PR failed Diffblue compatibility checks (cbmc commit: a3afbcf).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103506909
Status will be re-evaluated on next push.
Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)

  • the author is not in the list of contributors (e.g. first-time contributors).

  • the compatibility was already broken by an earlier merge.

@tautschnig tautschnig merged commit 35a0ac3 into diffblue:develop Mar 7, 2019
@tautschnig tautschnig deleted the is_goto_binary branch March 7, 2019 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants