Java: tolerate fields and classes with the name "nil" #4329
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
cristina-david,
NathanJPhillips,
peterschrammel,
pkesseli and
thk123
as code owners
tautschnig
reviewed
Mar 5, 2019
| @@ -352,7 +352,8 @@ class fieldref_exprt : public exprt | |||
| template <> | |||
| inline bool can_cast_expr<fieldref_exprt>(const exprt &base) | |||
| { | |||
| return base.get(ID_class) != ID_nil && base.get(ID_component_name) != ID_nil; | |||
| return base.get(ID_class) != ID_empty_string && | |||
There was a problem hiding this comment.
How about return !base.get(ID_class).empty() && !base.get(ID_component_name).empty();?
And while I'm at it: would mind adding a test case?
fieldref_exprt confused ID_nil with ID_empty_string and therefore rejected "class nil { int nil; }" for example.
smowton
force-pushed
the
smowton/fix/tolerate-nil-names
branch
from
4cd4cf3 to
796f7e1
Compare
allredj
reviewed
Mar 5, 2019
There was a problem hiding this comment.
This PR failed Diffblue compatibility checks (cbmc commit: 796f7e1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/103234960
Status will be re-evaluated on next push.
Common spurious failures:
-
the cbmc commit has disappeared in the mean time (e.g. in a force-push)
-
the author is not in the list of contributors (e.g. first-time contributors).
-
the compatibility was already broken by an earlier merge.
owen-mc-diffblue
approved these changes
Mar 6, 2019
tautschnig
approved these changes
Mar 6, 2019
peterschrammel
approved these changes
Mar 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fieldref_exprt confused ID_nil with ID_empty_string and therefore rejected "class nil { int nil; }" for example.