Skip to content

Add back two declarations needed for test-gen #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
+4 −0
Closed

Add back two declarations needed for test-gen #4328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/cbmc/bmc.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,6 +193,10 @@ class bmct:public safety_checkert

friend class bmc_all_propertiest;

// \todo remove these two declarations once test-gen dependency is fixed
bool cover(const goto_functionst &goto_functions);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❓ How does adding a declaration without definition help? Because TG provides a implementation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But ... this isn't declared virtual?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No - TG compiles and links a copy of bmc_cover.cpp with the bmct::cover directly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see - so it's technical debt coming to haunt you 👻

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does adding the declaration (but not a definition) make a difference?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh... wondered the same thing - I think the answer is we provide the definition in the test-gen repo. I vaguely remember some dark magic where we linked a different bmc_cover.cpp because it had diverged too much on the old branch...

friend class bmc_covert;

private:
/// \brief Class-specific symbolic execution
///
Expand Down