new constructor for function_application_exprt #4317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new constructor 1) moves the arguments 2) enforces the type of the function to be mathematical_function 3) automatically sets the type of the application to be the codomain of the function. 4) checks that the right number of arguments is given. Note that the function symbol can't be moved during construction as its type is needed. The types of the arguments are not checked.
kroening
requested review from
allredj,
martin-cs,
peterschrammel,
pkesseli,
romainbrenguier,
smowton and
tautschnig
as code owners
allredj
reviewed
Mar 3, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 493324d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102948379
tautschnig
approved these changes
Mar 3, 2019
| : binary_exprt( | ||
| _function, | ||
| ID_function_application, | ||
| multi_ary_exprt(irep_idt(), std::move(_arguments), typet()), |
There was a problem hiding this comment.
This looks very odd. Can we use ID_arguments? exprt{ID_arguments, std::move(_arguments)} would IMHO look cleaner. (But that's probably not possible until #3502 is merged.)
There was a problem hiding this comment.
Sure, could use ID_arguments, but could also contemplate something like ID_tuple (which is what is happening here).
There was a problem hiding this comment.
(Either should be a separate PR, and would need to change all constructors).
kroening
pushed a commit
that referenced
this pull request
Mar 4, 2019
This is follow-up from PR #4317. This introduces tuple_exprt. function_application_exprt now uses tuple_exprt for the argument operand, instead of an expression with empty ID.
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new constructor
function.
Note that the function symbol can't be moved during construction as its type
is needed.