MSVC build fixes #4299
Merged
MSVC build fixes #4299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/ansi-c/library_check.sh does not work under MSVC, as that compiler uses completely different flags. This commit removes the file generated by that script---library-check.stamp---from the dependency graph under cmake. This commit fixes diffblue#4295.
This commit indents CMake directives that got protected by a conditional in a previous commit.
This commit fixes failure-to-build on systems where the path to the compiler contains spaces. This is common on Microsoft Windows, where the compiler lives somewhere under `C:\Program Files`. Prior to this commit, src/ansi-c/library_check.sh would try to execute `C:\Program` and fail.
karkhaz
requested review from
kroening,
peterschrammel and
tautschnig
as code owners
tautschnig
approved these changes
Feb 28, 2019
|
I'll start playing with the CI set-up in #4300. |
allredj
reviewed
Feb 28, 2019
There was a problem hiding this comment.
✔️
Passed Diffblue compatibility checks (cbmc commit: 0bd112c).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/102644044
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches enable CBMC to be built using the MSVC compiler, under the Visual Studio developer console, using CMake---no cygwin or mingw. There are warnings galore, but it does build.
I don't know whether we're actually intending to support this particular build configuration; if so, it's probably a good idea to add it to CI. I don't have time to do this right now, but if there's interest, I'll add it as the ωth item on my backlog...